-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MF-942 - Fix email template logic #944
Conversation
Codecov Report
@@ Coverage Diff @@
## master #944 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 75 75
Lines 5244 5244
=======================================
Hits 4389 4389
Misses 588 588
Partials 267 267 Continue to review full report at Codecov.
|
users/README.md
Outdated
@@ -41,9 +41,9 @@ default values. | |||
| MF_EMAIL_PASSWORD | Mail server password | | | |||
| MF_EMAIL_FROM_ADDRESS | Email "from" address | | | |||
| MF_EMAIL_FROM_NAME | Email "from" name | | | |||
| MF_TOKEN_SECRET | Token secret for signing token used for password reset | | | |||
| MF_EMAIL_TEMPLATE | Email template for sending emails with password reset link | email.tmpl | | |||
| MF_TOKEN_SECRET | Password reset token signing secret | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align this properly
users/README.md
Outdated
``` | ||
|
||
if 'MF_EMAIL_TEMPLATE' doesn't point to any file service will function but password reset functionality will not work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentences start with capital letter.
Use backticks (``) rather than single qoutes.
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix email template Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * rename resetPasswEmail.tmpl Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add env var Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * rename resetPasswEmail.tmpl Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * rename resetPasswEmail.tmpl Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * upd docs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * upd docs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * upd docs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove not needed file Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * move email tmpl Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * move email tmpl Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * move email tmpl Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * variable for tmpl Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix ident and caps Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Which issue(s) does this PR fix/relate to?
Resolves #942
Did you document any new/modified functionality?
Yes